Meetings

Upcoming Meetings

2019-06-X

Arranged by: rubenwardy

Organisation discussion

• Is 5.0.2 needed for the newlines in setting name bug? (https://github.com/minetest/minetest/pull/8590)
• What is needed to have good mobs in Minetest / Minetest Game? I suggest roping in mob devs like tenplus1 and stujones1
• How best to manage Unarelith's refactors
• Combine pathfinder issues into a single issue

PR discussion/reviews

• Consistent formspec co-ords https://github.com/minetest/minetest/pull/8524
• Custom particle generators for particle spawners https://github.com/minetest/minetest/pull/6688
• Punchwear https://github.com/minetest/minetest/pull/6804
  • Who wants to adopt it? The feature was requested many times.
• InvRef: Add add_list https://github.com/minetest/minetest/pull/8466
  • Wanted feature or useless overhead?
• Custom item wear display https://github.com/minetest/minetest/pull/8447
  • Concept discussion. Acceptable PR or is there any better solution?
• /help formspec https://github.com/minetest/minetest/pull/8385
  • Concept discussion. Acceptable PR or what to change?

MTG discussion/reviews

• Craftguide from pauloue https://github.com/minetest/minetest_game/pull/2396
• Craftguide from LightWolfHT https://github.com/minetest/minetest_game/pull/2394

Proposed order of merging formspec PRs

The idea is to merge the most important PR first (top of list) to not drown in conflicts:

• real_coordinates[] https://github.com/minetest/minetest/pull/8524
• style[] https://github.com/minetest/minetest/pull/8383
• scroll_container[] https://github.com/minetest/minetest/pull/8591
• list spacing https://github.com/minetest/minetest/pull/7971 (perhaps integrate into style[]?)

Past Meetings

July-August 2018

Arranged by: Krock

Organisation discussion

• Will there be a 0.4.18 release?
  • http://irc.minetest.net/minetest-dev/2018-07-14#i_5358759 - sounds like a definitive "no"?
• Specify a rough 5.0.0 release date (month, year)
  • Freeze for multiple weeks for testing & fixing
• Forums: Clarify which rules (amongst license) apply for WIP modpacks/mods/games
  • https://forum.minetest.net/viewtopic.php?t=20630

PR discussion/reviews

• Colorize command parameters and privilege names (https://github.com/minetest/minetest/pull/7019)
  • Improves readability - does it need `string.format` for a possibly prettier code?
• Protocol cleanups https://github.com/minetest/minetest/pull/7348
  • Review needed (compat break)

June 2018

Arranged by: Krock

Organisation discussion

• Will there be a 0.4.18 release?
• Bugfixing the bugfix release
  • https://github.com/minetest/minetest/commit/014a1a08 fix for https://github.com/minetest/minetest/issues/6092
  • https://github.com/minetest/minetest/commit/a1598e1b (c_internal.cpp only) fix for https://github.com/minetest/minetest/issues/7419
• Proposal: change master version scheme to: 5.0.0

PR discussion/reviews

• Colorize command parameters and privilege names (https://github.com/minetest/minetest/pull/7019)
  • Improves readability - does it need `string.format` for a possibly prettier code?
• Lua parameter reading https://github.com/minetest/minetest/pull/7410
  • Good design concept? Comments?
• Protocol cleanups https://github.com/minetest/minetest/pull/7348
  • Review needed (compat break)
• CSM keypress - is this advantage acceptable? https://github.com/minetest/minetest/pull/7008
  • Needs flavors to be added: http://irc.minetest.net/minetest-dev/2018-06-11#i_5329651

2018-05-19

Arranged by: Krock

Proposed time: 18:00 UTC

Organisation discussion

• 0.4.17 - backport missing fixes and set date for freeze
  • ~Android-specific fix for https://pastebin.com/j4mjniaq must be added too (during freeze?)~
  • Needs buildbot fixes (404 packages)
  • Backport https://github.com/minetest/minetest/commit/4bb41a19d (http://irc.minetest.net/minetest-dev/2018-05-19#i_5310266)
• 0.4.17 - set release date

PR discussion/reviews

• Colorize command parameters and privilege names (https://github.com/minetest/minetest/pull/7019)
  • Improves readability - does it need `string.format` for a possibly prettier code?
• Fix missing ignore textures (https://github.com/minetest/minetest/pull/7326)
  • Needs more dev opinions & reviewing

2018-05-05

Arranged by: Krock

It's now almost a month since the last meeting - it time for the next one. Proposed time: 18:00 UTC

Organisation discussion

• When do we have time to release 0.4.17?
  • Still unclear freeze and release dates. 1 MTE needs backporting first
• Whether to leave the issue number link in a commit message when merging on Github
  • MTE: Keep the numbers if they're inserted automatically (high PR count, helpful for the web interface blame or fast jumps in commits)
  • MTG: The numbers may be removed if wanted (small amount of PRs)
  • http://irc.minetest.net/minetest-dev/2018-05-05#i_5298887

PR discussion/reviews

• Colorize command parameters and privilege names (https://github.com/minetest/minetest/pull/7019)
  • Improves readability - does it need `string.format` for a possibly prettier code?
• Abort when trying to set a not registered node (https://github.com/minetest/minetest/pull/7011)
  • Needs more dev opinions & reviewing

2018-04-07

Arranged by: Krock

Organisation discussion

• Questions related to 0.4.17, 0.4.18 or future development?
• 0.4.17 release should be moved to 21/22 April for backports (http://irc.minetest.net/minetest-dev/2018-04-07#i_5272834)
  • Feature/backport freeze after 14 April to have enough time for testing

PR discussion/review

• Android joystick (https://github.com/minetest/minetest/pull/7126)
• Formspecs: Add a <use_color_alpha> parameter to the box[] element (https://github.com/minetest/minetest/pull/7116)
  • Causes errors in-game for older clients but doesn't affect playability - merge or not?
• Colorize command parameters and privilege names (https://github.com/minetest/minetest/pull/7019)
  • Improves readability - does it need `string.format` for a possibly prettier code?

MTG discussion/reviews

• Tools: rebalance (https://github.com/minetest/minetest_game/issues/1681)
  • Needs either a levelling system and/or special abilities for different materials to add variety
  • paramat suggests removing bronze, which is incorrectly a stronger tool than steel (http://irc.minetest.net/minetest-dev/2018-04-07#i_5272959)
  • Future mese concept: http://irc.minetest.net/minetest-dev/2018-04-07#i_5273013

2018-03-31

Arranged by: Krock

PR discussion/reviews

• Introduce clang-tidy to the CI (https://github.com/minetest/minetest/pull/6295)
• Android joystick (https://github.com/minetest/minetest/pull/7126)
  • Minor change requests, discussion about joystick placement

0.4.17 release schedule

• Definitive release date
  • Announced. 15 April 2018, see https://forum.minetest.net/viewtopic.php?f=18&t=19905
• Any new, important bugfixes to backport?
  • Added the `core.rotate_node` bugfix, otherwise probably not. It's pretty much stable.
• Volunteer for cherry-picking the ToDo backport commits (https://github.com/minetest/minetest/pull/6746)
  • `<sfan5> probably me` (http://irc.minetest.net/minetest-dev/2018-03-31#i_5264276)

2018-03-10

Arranged by: Krock

Organisation discussion

• New Doxygen rule
  • Log: http://irc.minetest.net/minetest-dev/2018-03-10#i_5249578
  • Opposed: paramat, sfan5, SmallJoker, Shara
  • Comments in the functions directly are more welcome
• Group issues in projects?
  • Log: http://irc.minetest.net/minetest-dev/2018-03-10#i_5249600
  • Purpose is unclear and questionable due missing information, needs to be discussed later again

PR discussion/reviews

• Remove texture pack caching (https://github.com/minetest/minetest/pull/6660)
• Don’t create CSM script env (https://github.com/minetest/minetest/pull/6951)
  • Log: http://irc.minetest.net/minetest-dev/2018-03-10#i_5249625
  • Needs improvement, questionable solution due request of server-provided CSM (https://github.com/minetest/minetest/issues/5393)
• “Bugfix” for 0.4-backported rotate_node calls (https://github.com/minetest/minetest/pull/6900)
  • SmallJoker will test again and possibly merge after success
• Android C++11 build fix (https://github.com/minetest/minetest/pull/6796)
  • Log: http://irc.minetest.net/minetest-dev/2018-03-10#i_5249684
  • sfan5 and nerzhul will try to test it soon. It does not break the regular setup, so a merge is to expect soon
  • Confirmed working by Wayward_One (http://irc.minetest.net/minetest-dev/2018-03-10#i_5249720)
• Autogenerated settings header (https://github.com/minetest/minetest/pull/6728)
  • Log: http://irc.minetest.net/minetest-dev/2018-03-10#i_5249703 (stub)
  • Needs attention

0.4.17 release schedule

• Definitive release date
  • absent nerzhul: “release 0.4.17 ASAP” (http://irc.minetest.net/minetest-dev/2018-03-10#i_5249422)
• Are there any new, important bugfixes to backport?
• Volunteer for cherry-picking the 6 TODO (+ ^ from above) commits (https://github.com/minetest/minetest/pull/6746)

2017-04-29

Arranged by: paramat

ShadowNinja is unavailable today, paramat will be hosting in his stead.

Old business: (Things mentioned at previous meetings that haven't yet been resolved)

• "Add configurable key bindings" (#1439)
  • Rebased by nore, needs tweaks and merge.
• Additional hooks for inventory manipulations callbacks (#4035)
  • Krock is working on it, progress?
• Minetest subgame meeting
  • paramat held one at 1900Z
• Timed move (#1489)
  • Merge/close?
• Use a settings object for the main settings (#1949)
  • Rebased, should be merged soon.
• Split block position in SQLite3 database (and use R*Tree) (#1845)
  • Rebased, performance tests to do soon(tm).
  • nerzhul: performance is a little bit slower, but it's ridiculous compared to mapblock deserialization part (no bench to show it atm, but i did it 2 years ago on my fork, and SQLite was improved since this date)
• Add list_predict formspec element (#1988)
  • sofar worked on a rebase a while ago. Close or merge a modern version?

New business: (mainly oldest or least recently updated PRs that haven't been handled yet)

• Added formspec element 'KeyEventBox' for charbased input by ninnghazad (#1737)
  • Closed: better done with client-side mods.
• Use object property "stepheight" for player stepheight too. (#2056)
  • Agreed to merge, but nobody assigned.
• Add mapgen settings to create world dialog by srifqi (#2561)
  • Merge, but needs changes.